Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print coverage report #4

Merged
merged 1 commit into from
Apr 7, 2016
Merged

print coverage report #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions bin/coverage
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
#! /usr/bin/env node

'use strict'

const gulp = require('gulp')

require('../src/gulp-log')(gulp)
require('../gulp')(gulp)

gulp.start('coverage')
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
"dignified-lint": "bin/lint",
"dignified-build": "bin/build",
"dignified-test": "bin/test",
"dignified-release": "bin/release"
"dignified-release": "bin/release",
"dignified-coverage": "bin/coverage"
},
"scripts": {
"lint": "bin/lint"
Expand Down Expand Up @@ -40,6 +41,7 @@
"gulp-eslint": "^2.0.0",
"gulp-filter": "^4.0.0",
"gulp-git": "^1.7.1",
"gulp-istanbul": "^0.10.4",
"gulp-load-plugins": "^1.2.0",
"gulp-load-tasks": "^0.8.4",
"gulp-mocha": "^2.2.0",
Expand Down
30 changes: 30 additions & 0 deletions tasks/coverage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
'use strict'

const $ = require('gulp-load-plugins')()

const utils = require('../src/utils')
const config = require('../config/webpack')

module.exports = {
fn (gulp, done) {
gulp.task('pre-test', function () {
return gulp.src([
'src/**/*.js'
]).pipe($.istanbul())
.pipe($.istanbul.hookRequire())
})

gulp.task('mocha', ['pre-test'], () => {
return gulp.src([
'test/node.js',
'test/**/*.spec.js'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

13:40 no wait the globs for istanbul need to be the same as for mocha so it doesn't load browser.js

This is the same as https://github.com/dignifiedquire/dignified.js/blob/master/tasks/test/node.js#L12-L13

What else would you like me to add?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant make the one on l12 the same as this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We instrument the src on l12 with Istanbul, and run tests with mocha. We don't need to instrument the tests folder.

])
.pipe($.mocha({
timeout: config.dev.timeout
}))
.pipe($.istanbul.writeReports())
})

utils.hooksRun(gulp, 'coverage', ['mocha'], utils.exitOnFail(done))
}
}