Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no IPFS_JS_EXEC during 1st pass of test-external #498

Closed
wants to merge 1 commit into from
Closed

fix: no IPFS_JS_EXEC during 1st pass of test-external #498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/test-external/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,11 +111,17 @@ const testModule = async (targetDir, ipfsDir, ipfsPkg, httpClientPkg) => {
try {
// run the tests without our upgrade - if they are failing, no point in continuing
await exec('npm', ['test'], {
cwd: targetDir
cwd: targetDir,
env: {
// ensure custom js-ipfs is not used for the first run
IPFS_JS_EXEC: undefined
}
})
} catch (err) {
console.info(`Failed to run the tests of ${modulePkg.name}, aborting`, err.message) // eslint-disable-line no-console

// We won't be able to test if js-ipfs HEAD caused regression
// if upstream tests are broken. We abort and return exit code 0,
// as there is no point in breaking the build.
return
}

Expand Down