-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ts-jsdoc.md #703
Update ts-jsdoc.md #703
Conversation
"*": { | ||
"src/*": [ | ||
"dist/src/*", | ||
"dist/src/*/index" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this import path issue is caused by this line ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line works around microsoft/TypeScript#41284, but evidently src/*
pattern does not match import paths lib/src/
, hence workaround in this pull.
maybe we should stop using the if i remove We only have this workaround to deep import types, and the only package that should actually allow this is /cc @vasco-santos |
Yes, I think that could be the way to go.
libp2p/js-libp2p-interfaces and libp2p/js-libp2p-utils also need to support this though |
We keep the instructions on how to use typeVersions for these special repos and remove it from the default config. Sounds good ? Also these repos in general dont have the problem with the index entry point because they shouldn't have one single entry point by definition. |
Yes! |
Unfortunately TS still generates strange imports paths in various places e.g.
'multihashes'
is turned in the generated types intomultihashes/src/
which than is not caught by our types mapping. Which we could catch with additional mapping proposed by this pull request.