-
Notifications
You must be signed in to change notification settings - Fork 147
bitswap: link traces #1053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bitswap: link traces #1053
Conversation
|
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
9cd08a8 to
8d2c110
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1053 +/- ##
==========================================
+ Coverage 60.75% 60.77% +0.01%
==========================================
Files 268 268
Lines 33593 33600 +7
==========================================
+ Hits 20411 20420 +9
+ Misses 11510 11506 -4
- Partials 1672 1674 +2
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
This code seems reasonable, but I am not sure we want to add ProbeLab specific comments to our codebase. |
This was suggested by @lidel (not the specific phrasing, just the marks). The rationale was that we wanted to avoid our analysis code to break going forward into the future. |
Changelog:
handleIncomingplusreceived blockevents