Skip to content

Conversation

@dennis-tra
Copy link
Contributor

@dennis-tra dennis-tra commented Oct 14, 2025

Changelog:

  • added a new span to bitswap's handleIncoming plus received block events
  • marked the spans/attributes/events that we at ProbeLab use for our analysis

@dennis-tra dennis-tra requested a review from a team as a code owner October 14, 2025 10:12
@welcome
Copy link

welcome bot commented Oct 14, 2025

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@dennis-tra dennis-tra force-pushed the main branch 2 times, most recently from 9cd08a8 to 8d2c110 Compare October 14, 2025 11:39
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.77%. Comparing base (0f1ebac) to head (b59760b).
⚠️ Report is 6 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1053      +/-   ##
==========================================
+ Coverage   60.75%   60.77%   +0.01%     
==========================================
  Files         268      268              
  Lines       33593    33600       +7     
==========================================
+ Hits        20411    20420       +9     
+ Misses      11510    11506       -4     
- Partials     1672     1674       +2     
Files with missing lines Coverage Δ
bitswap/client/internal/getter/getter.go 83.75% <100.00%> (+1.08%) ⬆️
bitswap/client/internal/session/session.go 89.25% <100.00%> (ø)
bitswap/client/internal/tracing.go 100.00% <100.00%> (ø)
...uting/providerquerymanager/providerquerymanager.go 85.54% <100.00%> (+2.20%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gammazero
Copy link
Contributor

This code seems reasonable, but I am not sure we want to add ProbeLab specific comments to our codebase.

@dennis-tra
Copy link
Contributor Author

dennis-tra commented Oct 23, 2025

This code seems reasonable, but I am not sure we want to add ProbeLab specific comments to our codebase.

This was suggested by @lidel (not the specific phrasing, just the marks). The rationale was that we wanted to avoid our analysis code to break going forward into the future.

@gammazero gammazero merged commit 1f0df2e into ipfs:main Oct 25, 2025
14 checks passed
@lidel lidel mentioned this pull request Oct 29, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants