Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: return 400 on /ipfs/invalid-cid #205

Merged
merged 1 commit into from
Mar 20, 2023
Merged

feat: return 400 on /ipfs/invalid-cid #205

merged 1 commit into from
Mar 20, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Mar 15, 2023 •
edited
Loading

@codecov
Copy link

codecov bot commented Mar 15, 2023 •
edited
Loading

Codecov Report

Merging #205 (26fc7c0) into main (124ae4b) will increase coverage by 1.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   30.01%   31.19%   +1.18%     
==========================================
  Files         101      101              
  Lines       11312    11501     +189     
==========================================
+ Hits         3395     3588     +193     
+ Misses       7549     7540       -9     
- Partials      368      373       +5
Impacted Files Coverage Δ
gateway/errors.go 85.26% <100.00%> (+0.31%) ⬆️

... and 2 files with indirect coverage changes

@hacdias hacdias force-pushed the issue/200 branch 2 times, most recently from aee8a93 to 332cbe4 Compare March 15, 2023 15:22
@hacdias hacdias mentioned this pull request Mar 15, 2023
Merged
@hacdias hacdias self-assigned this Mar 15, 2023
@hacdias hacdias marked this pull request as ready for review March 15, 2023 15:31
@hacdias hacdias requested review from lidel and a team as code owners March 15, 2023 15:31
@hacdias hacdias mentioned this pull request Mar 15, 2023
Merged
@hacdias
Copy link
Member Author

hacdias commented Mar 20, 2023

Sharness and go tests passing in ipfs/kubo#9726. Merging.

@hacdias hacdias merged commit 3881551 into main Mar 20, 2023
@hacdias hacdias deleted the issue/200 branch March 20, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guseggert guseggert guseggert approved these changes

@lidel lidel Awaiting requested review from lidel lidel is a code owner

Assignees

@hacdias hacdias

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gateway: return 400 on /ipfs/invalid-cid
2 participants
@hacdias @guseggert