Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gw): panic in handler_car.go #255

Merged
merged 1 commit into from
Apr 3, 2023
Merged

fix(gw): panic in handler_car.go #255

merged 1 commit into from
Apr 3, 2023

Conversation

lidel
Copy link
Member

@lidel lidel commented Apr 3, 2023

Copy link
Contributor

@willscott willscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like it should fix setting the header to nil

lidel added a commit to ipfs-inactive/bifrost-gateway that referenced this pull request Apr 3, 2023
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #255 (67153ec) into main (95126f6) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
+ Coverage   48.07%   48.09%   +0.01%     
==========================================
  Files         270      270              
  Lines       33063    33064       +1     
==========================================
+ Hits        15896    15901       +5     
+ Misses      15496    15490       -6     
- Partials     1671     1673       +2     
Impacted Files Coverage Δ
gateway/handler_car.go 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

lidel added a commit to ipfs-inactive/bifrost-gateway that referenced this pull request Apr 3, 2023
@lidel
Copy link
Member Author

lidel commented Apr 3, 2023

Confirmed it works ipfs-inactive/bifrost-gateway#72 (comment)

@lidel lidel marked this pull request as ready for review April 3, 2023 20:44
@lidel lidel requested a review from hacdias as a code owner April 3, 2023 20:44
@lidel lidel merged commit 085ed9d into main Apr 3, 2023
@lidel lidel deleted the fix/panic-gw-car-handler branch April 3, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants