Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unixfs 1.5 inline metadata #317

Closed
wants to merge 1 commit into from
Closed

Support unixfs 1.5 inline metadata #317

wants to merge 1 commit into from

Conversation

iand
Copy link
Contributor

@iand iand commented May 28, 2023

This is a port of ipfs/go-unixfs#117

@iand iand requested a review from a team as a code owner May 28, 2023 16:52
@welcome
Copy link

welcome bot commented May 28, 2023

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Merging #317 (4ab7b86) into main (8ec71db) will increase coverage by 0.06%.
The diff coverage is 72.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
+ Coverage   48.26%   48.33%   +0.06%     
==========================================
  Files         279      279              
  Lines       33538    33672     +134     
==========================================
+ Hits        16187    16275      +88     
- Misses      15672    15708      +36     
- Partials     1679     1689      +10     
Impacted Files Coverage Δ
ipld/unixfs/pb/unixfs.pb.go 51.23% <38.88%> (-5.24%) ⬇️
ipld/unixfs/importer/balanced/builder.go 59.45% <66.66%> (+0.99%) ⬆️
ipld/unixfs/importer/helpers/dagbuilder.go 73.71% <81.81%> (+13.13%) ⬆️
ipld/unixfs/unixfs.go 75.18% <85.48%> (+3.35%) ⬆️
ipld/unixfs/importer/trickle/trickledag.go 53.78% <100.00%> (+0.19%) ⬆️
ipld/unixfs/io/dagreader.go 80.43% <100.00%> (+0.58%) ⬆️

... and 8 files with indirect coverage changes

@iand
Copy link
Contributor Author

iand commented Dec 11, 2023

Abandoned

@iand iand closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant