-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(routing/http): delegated IPNS server and client, IPIP 379 #333
Conversation
Codecov Report
@@ Coverage Diff @@
## main #333 +/- ##
==========================================
+ Coverage 49.74% 49.82% +0.07%
==========================================
Files 249 249
Lines 29994 30125 +131
==========================================
+ Hits 14920 15009 +89
- Misses 13645 13671 +26
- Partials 1429 1445 +16
|
b8a0ddb
to
3402424
Compare
Note that this PR will have to be rebased if #339 is merged first. |
I will address the feedback once we have the IPNS PRs complete then (or I might rebase it earlier if I have time). |
I rebased this on top of the IPNS PR to make the required changes. This also depends on a fix of Gateway sharness will fail until IPNS PR is merged. |
52305e7
to
7252809
Compare
7770545
to
eaf8cbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing tests, small nits below.
5a19956
to
043fb2f
Compare
will get this out tomorrow unless something gets in the way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @hacdias, I think its good enough to merge and iterate further in #422 + ipfs/kubo#9877.
ps. on windows TestClientOverMax
is flaky, i've re-run it.
This implements the Boxo client and server for ipfs/specs#379.