Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate go-unixfs into unixfs/ipld-merkledag #36

Closed
wants to merge 409 commits into from
Closed

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Jan 25, 2023

We have multiple and will have more unixfs implementations in the future.
So I think it could make sense to start migrating them like this, so the import path tells you which abstraction you are using. (go-unixfsnode would be unixfs/ipld-prime).

Depends on (include) #58
Depends on ipfs/go-block-format#37

Todo:

Kubuxu and others added 30 commits November 21, 2016 18:10
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>


This commit was moved from ipfs/go-unixfs@b736dc1
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>


This commit was moved from ipfs/go-unixfs@72df8b2
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>


This commit was moved from ipfs/go-unixfs@d6e8b60
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>


This commit was moved from ipfs/go-unixfs@b845e42
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>


This commit was moved from ipfs/go-unixfs@91871b4
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>


This commit was moved from ipfs/go-unixfs@b4c08b0
*** THIS IS A BREAKING CHANGE *** as per [1]: "Required is forever"

Nevertheless this seems like a good idea at this time: there are no known
producers ( nor consumers ) of MetaData nodes, and the current requirement
of MimeType has an extremely narrow application scope.

This change could very well be rejected in lieu of implementing a new type
of node ( e.g. TheRealMetadata ) in the DataType enum.

Based on ipfs/kubo#3451 (comment)

License: MIT
Signed-off-by: Mib Kd743naq <mib.kd743naq@gmail.com>

[1] https://developers.google.com/protocol-buffers/docs/proto#specifying-field-rules


This commit was moved from ipfs/go-unixfs@e94be52
License: MIT
Signed-off-by: Zander Mackie <zmackie@gmail.com>


This commit was moved from ipfs/go-unixfs@63cfd75
License: MIT
Signed-off-by: Zander Mackie <zmackie@gmail.com>


This commit was moved from ipfs/go-unixfs@2e3a9f7
License: MIT
Signed-off-by: Kevin Atkinson <k@kevina.org>


This commit was moved from ipfs/go-unixfs@4df1387
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>


This commit was moved from ipfs/go-unixfs@a3e7230
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>


This commit was moved from ipfs/go-unixfs@a0f5ffd
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>


This commit was moved from ipfs/go-unixfs@21a5430
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>


This commit was moved from ipfs/go-unixfs@c9a8a08
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>


This commit was moved from ipfs/go-unixfs@ba636f0
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>


This commit was moved from ipfs/go-unixfs@a6f8ee7
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>


This commit was moved from ipfs/go-unixfs@bd3637a
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>


This commit was moved from ipfs/go-unixfs@8bf6483
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>


This commit was moved from ipfs/go-unixfs@5e8347c
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>


This commit was moved from ipfs/go-unixfs@1f3adf3
License: MIT
Signed-off-by: Kevin Atkinson <k@kevina.org>


This commit was moved from ipfs/go-unixfs@123b0fd
…n nil

License: MIT
Signed-off-by: Kevin Atkinson <k@kevina.org>


This commit was moved from ipfs/go-unixfs@c1e9ccd
License: MIT
Signed-off-by: Kevin Atkinson <k@kevina.org>


This commit was moved from ipfs/go-unixfs@957da2c
License: MIT
Signed-off-by: Kevin Atkinson <k@kevina.org>


This commit was moved from ipfs/go-unixfs@e19161f
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>


This commit was moved from ipfs/go-unixfs@fb78dc2
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>


This commit was moved from ipfs/go-unixfs@a01e57d
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>


This commit was moved from ipfs/go-unixfs@4f4ba29
License: MIT
Signed-off-by: Zach Ramsay <zach.ramsay@gmail.com>


This commit was moved from ipfs/go-unixfs@ee18aaa
License: MIT
Signed-off-by: Zach Ramsay <zach.ramsay@gmail.com>


This commit was moved from ipfs/go-unixfs@427d991
@Jorropo Jorropo requested a review from hacdias January 25, 2023 19:39
@Jorropo Jorropo marked this pull request as draft January 26, 2023 04:17
@Jorropo
Copy link
Contributor Author

Jorropo commented Jan 26, 2023

Notes:
Do not merge now. I'll take care of reopening this once this is ready.

@Jorropo Jorropo self-assigned this Jan 26, 2023
@Jorropo Jorropo added the status/blocked Unable to be worked further until needs are met label Jan 26, 2023
Jorropo added a commit that referenced this pull request Jan 26, 2023
Jorropo added a commit that referenced this pull request Jan 26, 2023
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #36 (041e499) into main (302b279) will increase coverage by 9.04%.
The diff coverage is 63.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   18.50%   27.55%   +9.04%     
==========================================
  Files          96      110      +14     
  Lines       10337    12967    +2630     
==========================================
+ Hits         1913     3573    +1660     
- Misses       8152     8899     +747     
- Partials      272      495     +223     
Impacted Files Coverage Δ
unixfs/ipld-merkledag/file/unixfile.go 0.00% <0.00%> (ø)
unixfs/ipld-merkledag/io/resolve.go 0.00% <0.00%> (ø)
unixfs/ipld-merkledag/importer/importer.go 33.33% <33.33%> (ø)
unixfs/ipld-merkledag/test/utils.go 47.82% <47.82%> (ø)
...ixfs/ipld-merkledag/importer/trickle/trickledag.go 53.58% <53.58%> (ø)
unixfs/pb/unixfs.pb.go 56.47% <56.47%> (ø)
unixfs/ipld-merkledag/mod/dagmodifier.go 57.21% <57.21%> (ø)
unixfs/ipld-merkledag/importer/balanced/builder.go 57.57% <57.57%> (ø)
...ixfs/ipld-merkledag/importer/helpers/dagbuilder.go 61.23% <61.23%> (ø)
unixfs/ipld-merkledag/io/directory.go 62.70% <62.70%> (ø)
... and 4 more

@Jorropo Jorropo force-pushed the unixfs branch 4 times, most recently from dfae82e to e74087b Compare January 26, 2023 08:16
This is needed because the unixfs tests imports go-block-format.
@Jorropo Jorropo removed the status/blocked Unable to be worked further until needs are met label Jan 31, 2023
@Jorropo Jorropo marked this pull request as ready for review January 31, 2023 17:49
go.mod & go.sum conflict resolution
@rvagg
Copy link
Member

rvagg commented Jan 31, 2023

I hope the use of the name "merkledag" in this doesn't mean you're intending to pull in go-merkledag .. we really need that package to be retired over time, not baked in to some official thing

@Jorropo
Copy link
Contributor Author

Jorropo commented Jan 31, 2023

@rvagg, I havn't thought about go-merkledag yet, I don't really mind migrating here and removing it a few months later.

The main goal of naming it ipld-merkledag is to leave space for other unixfs implementations in that package.

@Jorropo
Copy link
Contributor Author

Jorropo commented Jan 31, 2023

@rvagg it's on the list ipfs/kubo#8543 (comment) 🤷

@rvagg
Copy link
Member

rvagg commented Feb 1, 2023

🤦 we're never going to kill these repos .. just shuffle them around, making breaking changes, aggravating our ecosystem; this is not a great idea. It might serve Kubo nicely, but I don't see how it serves anyone else.

@Jorropo
Copy link
Contributor Author

Jorropo commented Feb 13, 2023

Not doing that now

@Jorropo Jorropo closed this Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.