Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gateway): normalization of DNSLink inlining #462

Merged
merged 4 commits into from
Sep 19, 2023

Conversation

lidel
Copy link
Member

@lidel lidel commented Sep 18, 2023

This fix ensures inlined DNSLink identifies are normalized correctly in edge case when the value is passed to the PATH router at subdomain gateway:

With InlineDNSLink=false:

  • http://localhost:8080/ipns/my-v--long-example-comhttp://my.v-long.example.com.ipns.localhost:8080

With InlineDNSLink=true:

  • https://dweb.link/ipns/my-v--long-example-comhttps://my-v--long-example-com.ipns.dweb.link

This is quality of life improvement for users and tools who blindly copy&paste and helps with ipfs-companion edge case described in ipfs/ipfs-companion#1278 (comment).

This fix ensures inlined identifies on paths are normalized correctly
in edge case when inlined value is passed to the path router.
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #462 (745cee6) into main (574df96) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
- Coverage   66.47%   66.42%   -0.06%     
==========================================
  Files         207      207              
  Lines       24681    24692      +11     
==========================================
- Hits        16407    16401       -6     
- Misses       6851     6863      +12     
- Partials     1423     1428       +5     
Files Changed Coverage Δ
gateway/hostname.go 74.54% <100.00%> (+0.74%) ⬆️

... and 13 files with indirect coverage changes

@hacdias hacdias requested a review from a team as a code owner September 19, 2023 09:53
@hacdias hacdias enabled auto-merge (squash) September 19, 2023 10:33
@hacdias hacdias merged commit 68914ea into main Sep 19, 2023
14 checks passed
@lidel lidel deleted the fix/disabling-dnslink-inlining branch October 18, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants