fix(gateway): normalization of DNSLink inlining #462
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix ensures inlined DNSLink identifies are normalized correctly in edge case when the value is passed to the PATH router at subdomain gateway:
With
InlineDNSLink=false
:http://localhost:8080/ipns/my-v--long-example-com
→http://my.v-long.example.com.ipns.localhost:8080
With
InlineDNSLink=true
:https://dweb.link/ipns/my-v--long-example-com
→https://my-v--long-example-com.ipns.dweb.link
This is quality of life improvement for users and tools who blindly copy&paste and helps with ipfs-companion edge case described in ipfs/ipfs-companion#1278 (comment).