generated from ipfs/ipfs-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bitswap/client: explain what the options do #488
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #488 +/- ##
==========================================
+ Coverage 65.58% 65.61% +0.03%
==========================================
Files 207 207
Lines 25540 25540
==========================================
+ Hits 16750 16758 +8
+ Misses 7323 7315 -8
Partials 1467 1467
|
Jorropo
requested changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not write text that is gonna be outdated once we change this, I people to do 1 click if they want to follow the constant.
Jorropo
approved these changes
Nov 18, 2023
Jorropo
previously requested changes
Nov 18, 2023
hsanjuan
force-pushed
the
bsclient-docs
branch
from
November 22, 2023 11:29
a0cd395
to
eb85caa
Compare
hacdias
approved these changes
Nov 22, 2023
Added godoc explanation of what the client options do in more detail, since given information was useless.
hacdias
force-pushed
the
bsclient-docs
branch
from
November 22, 2023 13:51
eb85caa
to
9999444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added godoc explanation of what the client options do in more detail, since given information was useless.