Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitswap/client: explain what the options do #488

Merged
merged 3 commits into from
Nov 22, 2023
Merged

bitswap/client: explain what the options do #488

merged 3 commits into from
Nov 22, 2023

Conversation

hsanjuan
Copy link
Contributor

Added godoc explanation of what the client options do in more detail, since given information was useless.

@hsanjuan hsanjuan requested a review from a team as a code owner October 13, 2023 16:28
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #488 (9999444) into main (fe55533) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
+ Coverage   65.58%   65.61%   +0.03%     
==========================================
  Files         207      207              
  Lines       25540    25540              
==========================================
+ Hits        16750    16758       +8     
+ Misses       7323     7315       -8     
  Partials     1467     1467              
Files Coverage Δ
bitswap/client/client.go 88.12% <100.00%> (ø)

... and 12 files with indirect coverage changes

Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not write text that is gonna be outdated once we change this, I people to do 1 click if they want to follow the constant.

bitswap/client/client.go Outdated Show resolved Hide resolved
bitswap/client/client.go Outdated Show resolved Hide resolved
@hsanjuan hsanjuan requested a review from Jorropo October 18, 2023 10:47
@hsanjuan hsanjuan self-assigned this Oct 18, 2023
bitswap/internal/defaults/defaults.go Outdated Show resolved Hide resolved
@hacdias hacdias enabled auto-merge (rebase) November 22, 2023 13:51
@hacdias hacdias enabled auto-merge (squash) November 22, 2023 13:51
@hacdias hacdias merged commit 438b8a6 into main Nov 22, 2023
14 checks passed
@hacdias hacdias deleted the bsclient-docs branch November 22, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants