Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreiface: remove and move to Kubo #517

Merged
merged 1 commit into from
Nov 29, 2023
Merged

coreiface: remove and move to Kubo #517

merged 1 commit into from
Nov 29, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Nov 29, 2023

Removes coreiface package which is an intrinsic part of Kubo. We haven't done it before because of the path package, which has now been completely revamped. This will simplify new features when we need to update or add new thing to the API, such as ipfs/kubo#10235.

@hacdias hacdias mentioned this pull request Nov 29, 2023
2 tasks
@hacdias hacdias self-assigned this Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #517 (f84653a) into main (d06f7ff) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
- Coverage   65.59%   65.58%   -0.02%     
==========================================
  Files         207      207              
  Lines       25543    25543              
==========================================
- Hits        16756    16753       -3     
  Misses       7320     7320              
- Partials     1467     1470       +3     

see 13 files with indirect coverage changes

@hacdias hacdias requested a review from Jorropo November 29, 2023 09:31
@hacdias hacdias marked this pull request as ready for review November 29, 2023 09:31
@hacdias hacdias requested a review from a team as a code owner November 29, 2023 09:31
Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@hacdias hacdias merged commit 08959f2 into main Nov 29, 2023
15 checks passed
@hacdias hacdias deleted the remove-coreapi branch November 29, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants