Release v0.17.0 #542
Merged
Release v0.17.0 #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge Release v0.16.0
…nlined and folded at compiletime Fixes #67
From: ``` init github.com/ipfs/boxo/gateway/assets @26 ms, 18 ms clock, 9887320 bytes, 1496 allocs ``` To: ``` init github.com/ipfs/boxo/gateway/assets @10 ms, 3.3 ms clock, 3368 bytes, 11 allocs ``` This is not optimal but better solutions (like lazy loading) require breaking the API and it's a better job for future someone else.
It appears there's a typo in the package name. It should be opentelemetry-go instead of opentelemtry-go.
blockservice is explicitely tolerent to having a nil exchange. The constructor even logs that as running an offline blockservice. Everything is tolerent except close, which panics. It is confusing for consumers to only have to call close based on if it's online or offline. They could also instead call close directly on the exchange (then we could remove blockservice's Close method). Anyway here is as a simple fix, add a nil check.
Jorropo
approved these changes
Jan 10, 2024
Codecov ReportAttention:
@@ Coverage Diff @@
## release #542 +/- ##
===========================================
- Coverage 65.66% 65.60% -0.06%
===========================================
Files 207 207
Lines 25543 25590 +47
===========================================
+ Hits 16772 16789 +17
- Misses 7306 7328 +22
- Partials 1465 1473 +8
|
hacdias
force-pushed
the
release-v0.17.0
branch
from
2a28291
to
ad4e2b2
Compare
|
Suggested version: Changes in (empty)
Cutting a Release (and modifying non-markdown files)This PR is modifying both Automatically created GitHub ReleaseA draft GitHub Release has been created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister Kubo PR: ipfs/kubo#10285