Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockservice: add NewSessionContext and EmbedSessionInContext #549

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Jan 12, 2024

No description provided.

@Jorropo Jorropo requested a review from a team as a code owner January 12, 2024 11:13
Copy link
Contributor Author

Jorropo commented Jan 12, 2024

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (922c66c) 65.54% compared to head (8109917) 65.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
+ Coverage   65.54%   65.61%   +0.07%     
==========================================
  Files         207      207              
  Lines       25594    25606      +12     
==========================================
+ Hits        16775    16802      +27     
+ Misses       7346     7334      -12     
+ Partials     1473     1470       -3     
Files Coverage Δ
blockservice/blockservice.go 75.17% <86.45%> (-1.09%) ⬇️

... and 11 files with indirect coverage changes

@hacdias hacdias force-pushed the 01-12-blockservice_add_NewSessionContext_and_EmbedSessionInContext_ branch from 6c590b8 to 39f6a56 Compare January 12, 2024 12:26
Copy link
Member

hacdias commented Jan 12, 2024

Merge activity

  • Jan 12, 7:27 AM: Graphite rebased this pull request as part of a merge.
  • Jan 12, 7:27 AM: The Graphite merge of this pull request was cancelled.
  • Jan 12, 7:42 AM: @Jorropo started a stack merge that includes this pull request via Graphite.
  • Jan 12, 7:42 AM: @Jorropo merged this pull request with Graphite.

CHANGELOG.md Outdated Show resolved Hide resolved
This also include cleanup for session code.
@Jorropo Jorropo force-pushed the 01-12-blockservice_add_NewSessionContext_and_EmbedSessionInContext_ branch from 39f6a56 to 8109917 Compare January 12, 2024 12:29
@Jorropo Jorropo requested a review from hacdias January 12, 2024 12:34
@Jorropo Jorropo merged commit 22fa8b1 into main Jan 12, 2024
15 of 17 checks passed
Jorropo added a commit that referenced this pull request Feb 14, 2024
This brings us to a state before #549 back then I also did cleanup in this session code, that I have kept, I only removed the sessions in context feature.
Jorropo added a commit that referenced this pull request Feb 14, 2024
This brings us to a state before #549 back then I also did cleanup in this session code, that I have kept, I only removed the sessions in context feature.
Jorropo added a commit that referenced this pull request Feb 16, 2024
This brings us to a state before #549 back then I also did cleanup in this session code, that I have kept, I only removed the sessions in context feature.
Jorropo added a commit that referenced this pull request Feb 16, 2024
This brings us to a state before #549 back then I also did cleanup in this session code, that I have kept, I only removed the sessions in context feature.
hacdias pushed a commit that referenced this pull request Feb 27, 2024
This brings us to a state before #549 back then I also did cleanup in this session code, that I have kept, I only removed the sessions in context feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants