refactor(bitswap): unify logger names #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use uniform pattern for logger naming: bitswap/pkgname Slash delimiters are used to separate path segments used in logger names. This follows the conventios used most commonly in other parts of boxo.
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #637 +/- ##
==========================================
- Coverage 59.86% 59.82% -0.05%
==========================================
Files 238 238
Lines 29976 29976
==========================================
- Hits 17946 17932 -14
- Misses 10416 10429 +13
- Partials 1614 1615 +1
|
lidel
changed the title
lidel
approved these changes
Jul 9, 2024
wenyue
pushed a commit
to wenyue/boxo
that referenced
this pull request
Oct 17, 2024
* Unify bitswap logger names Use uniform pattern for logger naming: bitswap/pkgname Slash delimiters are used to separate path segments used in logger names. This follows the conventios used most commonly in other parts of boxo. * Update CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use uniform pattern for logger naming: bitswap/pkgname
Slash delimiters are used to separate path segments used in logger names. This follows the convention used most commonly in other parts of boxo.