test: use ipfs/go-test to consolidate code to generate test data #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #638 +/- ##
==========================================
- Coverage 59.92% 59.88% -0.04%
==========================================
Files 238 237 -1
Lines 30052 29958 -94
==========================================
- Hits 18008 17940 -68
+ Misses 10428 10403 -25
+ Partials 1616 1615 -1
|
Jorropo
reviewed
Jul 14, 2024
gammazero
force-pushed
the
chore/use-go-test
branch
from
679f47e
to
7ee586e
Compare
The go-test packages provides functionality for common types of test data generation. Use go-test for generating test data instead of internal utility packages. The random test data can be generated deterministically by setting an initial seed if doing so is necessary to recreate certain test data.
Return rand.Rand in place of util.randGen. The type util.randGen was only used to provide a Read method as an alternative to using the rand.Rand read method.
gammazero
force-pushed
the
chore/use-go-test
branch
from
872123c
to
338e10e
Compare
lidel
changed the title
lidel
approved these changes
Jul 30, 2024
wenyue
pushed a commit
to wenyue/boxo
that referenced
this pull request
Oct 17, 2024
…s#638) * Use ipfs/go-test to consolidate code to generate test data The go-test packages provides functionality for common types of test data generation. Use go-test for generating test data instead of internal utility packages. The random test data can be generated deterministically by setting an initial seed if doing so is necessary to recreate certain test data. Return `rand.Rand` in place of `util.randGen`. The type `util.randGen` was only used to provide a `Read` method as an alternative to using the `rand.Rand.Read` method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go-test packages provides functionality for common types of test data generation. Use go-test for generating test data instead of internal utility packages.
The random test data can be generated deterministically by setting an initial seed if doing so is necessary to recreate certain test data.