Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor performance improvements in bitswap #666

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

gammazero
Copy link
Contributor

Reduce lock contention, gc load, and other minor performance improvements.

Reduce lock contention, gc load, and other minor performance improvements.
@gammazero gammazero requested a review from a team as a code owner September 5, 2024 14:58
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 93.87755% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.24%. Comparing base (317eb7d) to head (f4c485f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...swap/server/internal/decision/blockstoremanager.go 93.61% 2 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
+ Coverage   60.20%   60.24%   +0.03%     
==========================================
  Files         241      241              
  Lines       30681    30707      +26     
==========================================
+ Hits        18473    18498      +25     
  Misses      10560    10560              
- Partials     1648     1649       +1     
Files with missing lines Coverage Δ
bitswap/server/internal/decision/engine.go 91.78% <100.00%> (-0.06%) ⬇️
...swap/server/internal/decision/blockstoremanager.go 90.75% <93.61%> (-0.26%) ⬇️

... and 16 files with indirect coverage changes

@lidel lidel merged commit 8726a2a into main Sep 5, 2024
15 checks passed
@lidel lidel deleted the chore/bitswap-performance branch September 5, 2024 16:52
@lidel
Copy link
Member

lidel commented Sep 5, 2024

ps. congrats on PR number 😈

wenyue pushed a commit to wenyue/boxo that referenced this pull request Oct 17, 2024
Reduce lock contention, gc load, and other minor performance improvements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants