generated from ipfs/ipfs-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bitswap performance issue #692
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gammazero
commented
Oct 17, 2024
•
edited
Loading
edited
- Fix exhausted wants problem resulting in possible performance issue
- Minor improvements for GC and execution
gammazero
force-pushed
the
chore/bitswap-client-perf
branch
from
October 17, 2024 21:05
40663fb
to
ac4c801
Compare
lidel
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b2554a00b246
looked ok at rainbow staging (staging-2024-10-18-73ff85c
):
https://www.notion.so/boxo-690-bitswap-s-live-wantlist-fix-1221def3428780148536c7cca992a07a
Just needs changelog + landing #690 first.
- Fix exhausted wants problem resulting in possible performance issue - Minor improvements for GC.
gammazero
force-pushed
the
chore/bitswap-client-perf
branch
from
October 18, 2024 18:26
b2554a0
to
048f932
Compare
gammazero
added a commit
that referenced
this pull request
Oct 22, 2024
- Fix exhausted wants problem resulting in possible performance issue - Minor improvements for GC. - RWLock not justified for time reading - replace unneeded RWMutex with Mutex - build strings with strings.Builder (cherry picked from commit 19bcc75)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.