Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on goprocess #710

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Remove dependency on goprocess #710

wants to merge 2 commits into from

Conversation

gammazero
Copy link
Contributor

The dependency on goprocess is not needed by boxo, and removing it removes the need to support it in code dependent on boxo.

Closes #709

The dependency on goprocess is not needed by boxo, and removing it removes the need to support it in code dependent on boxo.

Closes #709
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 72.99270% with 37 lines in your changes missing coverage. Please review.

Project coverage is 60.39%. Comparing base (29598b2) to head (d15e952).

Files with missing lines Patch % Lines
bootstrap/bootstrap.go 39.62% 31 Missing and 1 partial ⚠️
bitswap/server/server.go 92.50% 3 Missing ⚠️
bitswap/client/client.go 81.81% 2 Missing ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #710   +/-   ##
=======================================
  Coverage   60.39%   60.39%           
=======================================
  Files         243      243           
  Lines       31025    31040   +15     
=======================================
+ Hits        18737    18747   +10     
- Misses      10621    10627    +6     
+ Partials     1667     1666    -1     
Files with missing lines Coverage Δ
bitswap/bitswap.go 67.05% <100.00%> (-0.39%) ⬇️
bitswap/server/internal/decision/engine.go 91.48% <100.00%> (+0.04%) ⬆️
namesys/republisher/repub.go 61.26% <100.00%> (+2.60%) ⬆️
bitswap/client/client.go 87.93% <81.81%> (-0.14%) ⬇️
bitswap/server/server.go 63.08% <92.50%> (-1.13%) ⬇️
bootstrap/bootstrap.go 30.90% <39.62%> (-1.05%) ⬇️

... and 8 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on goprocess
1 participant