Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bitswap): log unexpected blocks to debug level #711

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

lidel
Copy link
Member

@lidel lidel commented Nov 4, 2024

With recent fixes we may be hitting case where we receive "unexpected" block more often (dropping wantlist overflow etc).

This produces unactionable error in logs, for example, kubo staging box:

Nov 04 17:14:40 kubo-staging-us-east-02 ipfs[14572]: 2024-11-04T17:14:40.556Z        ERROR        bitswap/client/provqrymgr        providerquerymanager/providerquerymanager.go:358        Received provider (QmQzqxhK82kAmKvARFZSkUVS6fo9sySaiogAnx5EnZ6ZmC) for cid (bafybeieooer53vz7sm33oxxj4xbx4iw2nir74m7hpg43ph4oluabsn6eja) not requested
Nov 04 17:32:57 kubo-staging-us-east-02 ipfs[14572]: 2024-11-04T17:32:57.367Z        ERROR        bitswap/client/provqrymgr        providerquerymanager/providerquerymanager.go:358        Received provider (QmQzqxhK82kAmKvARFZSkUVS6fo9sySaiogAnx5EnZ6ZmC) for cid (bafybeihv3ykvji2jmhvxpnbydcoe5wkips3fvdvav3yxvfbbrqcjbphgxq) not requested
Nov 04 17:33:55 kubo-staging-us-east-02 ipfs[14572]: 2024-11-04T17:33:55.923Z        ERROR        bitswap/client/provqrymgr        providerquerymanager/providerquerymanager.go:358        Received provider (12D3KooWKvFjYQ3R2uXRxpPA77iN7e1CfrGFjEXHB5vBKmim2tjw) for cid (bafkreig3473pmj27yolvzlxy3nwqt47vtvgqaalgr7l734bnzzlsmcr5da) not requested
Nov 04 17:33:55 kubo-staging-us-east-02 ipfs[14572]: 2024-11-04T17:33:55.930Z        ERROR        bitswap/client/provqrymgr        providerquerymanager/providerquerymanager.go:358        Received provider (QmQzqxhK82kAmKvARFZSkUVS6fo9sySaiogAnx5EnZ6ZmC) for cid (bafkreig3473pmj27yolvzlxy3nwqt47vtvgqaalgr7l734bnzzlsmcr5da) not requested
Nov 04 17:35:29 kubo-staging-us-east-02 ipfs[14572]: 2024-11-04T17:35:29.834Z        ERROR        bitswap/client/provqrymgr        providerquerymanager/providerquerymanager.go:358        Received provider (12D3KooWKvFjYQ3R2uXRxpPA77iN7e1CfrGFjEXHB5vBKmim2tjw) for cid (bafkreiaynygymin4wlzbf7hhzjjy6yjnmehzcmqkftkjqnfhdk2w6pkavq) not requested

I feel due to nature of this error, it should be a debug level, and not Error.

@lidel lidel requested a review from gammazero November 4, 2024 17:42
@lidel lidel requested a review from a team as a code owner November 4, 2024 17:42
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.42%. Comparing base (255419d) to head (225694b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ernal/providerquerymanager/providerquerymanager.go 0.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #711      +/-   ##
==========================================
+ Coverage   60.40%   60.42%   +0.02%     
==========================================
  Files         243      243              
  Lines       31025    31025              
==========================================
+ Hits        18740    18747       +7     
+ Misses      10622    10617       -5     
+ Partials     1663     1661       -2     
Files with missing lines Coverage Δ
...ernal/providerquerymanager/providerquerymanager.go 86.69% <0.00%> (-1.53%) ⬇️

... and 7 files with indirect coverage changes

@lidel lidel mentioned this pull request Nov 6, 2024
27 tasks
@lidel lidel merged commit f98e66c into main Nov 7, 2024
15 checks passed
@lidel lidel deleted the fix-debug-bitswap-client branch November 7, 2024 00:42
lidel added a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant