Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo Fix in scoreledger.go #766

Closed
wants to merge 1 commit into from
Closed

Conversation

teenager-ETH
Copy link

Typo Fix in scoreledger.go

Description:

This pull request fixes a typo in the scoreledger.go file, changing "immediatly" to the correct spelling "immediately" in the comment.

Changes:

  • Fixed typo in comment at line 109 of scoreledger.go.

File Changed:

  • bitswap/server/internal/decision/scoreledger.go

Diff:

@@ -109,7 +109,7 @@ type DefaultScoreLedger struct {
    scorePeer ScorePeerFunc
    // is closed on Close
    closing chan struct{}
    // protects the fields immediatly below
    // protects the fields immediately below
    lock sync.RWMutex
    // ledgerMap lists score ledgers by their partner key.
    ledgerMap map[peer.ID]*scoreledger

-->

@teenager-ETH teenager-ETH requested a review from a team as a code owner December 18, 2024 21:38
Copy link

welcome bot commented Dec 18, 2024

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@gammazero
Copy link
Contributor

Thank you. There are a number of places where minor spelling and wording changes will be made. This will be done in a separate PR that exists to accumulate such minor changes.

gammazero added a commit that referenced this pull request Dec 19, 2024
This is an accumulation of minor spelling and wording changes.

Closes #766
@gammazero gammazero closed this in a3da241 Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants