New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs/ipfs Contribute File #63

Closed

RichardLitt opened this issue Oct 28, 2015 · 1 comment

Member

RichardLitt commented Oct 28, 2015

https://github.com/ipfs/ipfs/blob/master/CONTRIBUTE.md does not link to ipfs/community/contribute.md, and I think it should.

I also think that it and https://github.com/ipfs/go-ipfs/blob/master/contribute.md have content which should be merged. So, I think I should rewrite them both to make them more project specific, and take out overlapping statements and put that into ipfs/community/contribute.md. Opening this here to see if there is consensus on this before I open PRs.

Member

jbenet commented Nov 2, 2015

Sounds good 👍

RichardLitt added a commit to RichardLitt/ipfs that referenced this issue


          Touched up contribute, linked to community docs

31fd30b

ipfs/community#63

RichardLitt mentioned this issue

Touched up contribute, linked to community docs ipfs/ipfs#117

Merged

RichardLitt added a commit to ipfs/kubo that referenced this issue


          Moved email juan to ipfs/contribute

dd72eb6

This was part of ipfs/community#63

License: MIT
Signed-off-by: Richard Littauer <richard.littauer@gmail.com>

RichardLitt added a commit to ipfs/kubo that referenced this issue


          Added commit sign off section

be334f3

This was in the main contributing guidelines, but is only enforced in this repo. I've added it here.

As part of ipfs/community#63

License: MIT
Signed-off-by: Richard Littauer <richard.littauer@gmail.com>

RichardLitt added a commit that referenced this issue


          Added note about emailing Juan

951df7e

This was in the main ipfs/ipfs repo, and belonged here too. I also removed a
couple of blank lines.

See #63 for more.

RichardLitt added a commit that referenced this issue


          Removed the commit sign-off section

76dd5fc

This is only used in go-ipfs. I have moved it to the contribution guidelines for that repository, and will open a PR on that immediately. I ran into at least one contributor who was intimidated by this section, and it is not currently mandatory for all repositories (although it potentially should be).

Done as part of #63

This was referenced Nov 2, 2015

Edited contribute ipfs/kubo#1927

Merged

Editing contributing #65

Merged

rht pushed a commit to rht/go-ipfs that referenced this issue


          Moved email juan to ipfs/contribute

63367b0

This was part of ipfs/community#63

License: MIT
Signed-off-by: Richard Littauer <richard.littauer@gmail.com>

rht pushed a commit to rht/go-ipfs that referenced this issue


          Added commit sign off section

b6beb2a

This was in the main contributing guidelines, but is only enforced in this repo. I've added it here.

As part of ipfs/community#63

License: MIT
Signed-off-by: Richard Littauer <richard.littauer@gmail.com>

RichardLitt added a commit that referenced this issue


          Added note about emailing Juan

f5d2d53

This was in the main ipfs/ipfs repo, and belonged here too. I also removed a
couple of blank lines.

See #63 for more.

RichardLitt added a commit that referenced this issue


          Removed the commit sign-off section

52d9b9d

This is only used in go-ipfs. I have moved it to the contribution guidelines for that repository, and will open a PR on that immediately. I ran into at least one contributor who was intimidated by this section, and it is not currently mandatory for all repositories (although it potentially should be).

Done as part of #63

RichardLitt added a commit to ipfs/kubo that referenced this issue


          Moved email juan to ipfs/contribute

a477fff

This was part of ipfs/community#63

License: MIT
Signed-off-by: Richard Littauer <richard.littauer@gmail.com>

RichardLitt added a commit to ipfs/kubo that referenced this issue


          Added commit sign off section

75f2ef0

This was in the main contributing guidelines, but is only enforced in this repo. I've added it here.

As part of ipfs/community#63

License: MIT
Signed-off-by: Richard Littauer <richard.littauer@gmail.com>

RichardLitt added a commit to ipfs/kubo that referenced this issue


          Moved email juan to ipfs/contribute

44dba09

This was part of ipfs/community#63

License: MIT
Signed-off-by: Richard Littauer <richard.littauer@gmail.com>

RichardLitt added a commit to ipfs/kubo that referenced this issue


          Added commit sign off section

fbeaa36

This was in the main contributing guidelines, but is only enforced in this repo. I've added it here.

As part of ipfs/community#63

License: MIT
Signed-off-by: Richard Littauer <richard.littauer@gmail.com>

RichardLitt added a commit to ipfs/kubo that referenced this issue


          Moved email juan to ipfs/contribute

a01957b

This was part of ipfs/community#63

License: MIT
Signed-off-by: Richard Littauer <richard.littauer@gmail.com>

RichardLitt added a commit to ipfs/kubo that referenced this issue


          Added commit sign off section

5de8e61

This was in the main contributing guidelines, but is only enforced in this repo. I've added it here.

As part of ipfs/community#63

License: MIT
Signed-off-by: Richard Littauer <richard.littauer@gmail.com>

RichardLitt closed this as completed

RichardLitt added a commit that referenced this issue


          Added note about emailing Juan

83e7977

This was in the main ipfs/ipfs repo, and belonged here too. I also removed a
couple of blank lines.

See #63 for more.

RichardLitt added a commit that referenced this issue


          Removed the commit sign-off section

f533406

This is only used in go-ipfs. I have moved it to the contribution guidelines for that repository, and will open a PR on that immediately. I ran into at least one contributor who was intimidated by this section, and it is not currently mandatory for all repositories (although it potentially should be).

Done as part of #63

RichardLitt added a commit that referenced this issue


          Small edits

b1c8309

Added note about emailing Juan

This was in the main ipfs/ipfs repo, and belonged here too. I also removed a
couple of blank lines.

See #63 for more.

RichardLitt added a commit that referenced this issue


          Small edits

98d4664

Added note about emailing Juan

This was in the main ipfs/ipfs repo, and belonged here too. I also removed a
couple of blank lines.

See #63 for more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment