Latest coverage updates and npmignore #119
Conversation
|
awesome! :D |
| ##### `.gitignore` | ||
|
|
||
| To avoid checking in the dist and lib folders, the `.gitignore` file should at least contain: | ||
| To avoid checking in unwanted files, the `.gitignore` file should follow | ||
| this [example](examples/.gitignore). |
There was a problem hiding this comment.
The word should is a bit hard. This should be reworded to say 'A .gitignore is useful. An example is provided in examples'
There was a problem hiding this comment.
I disagree, not having this .gitignore can mess up a lot of the rest in this document, and create a lot of other problems, so having if is a "should" surley
There was a problem hiding this comment.
This document isn't only for large js-ipfs-* style projects. It is also for small javascript projects that frankly do not need all of these things. The .gitignore here seems excessively bloated for some smaller repos. For example, dnslink-deploy is a JS repo that doesn't need this.
There was a problem hiding this comment.
Note that the .gitignore you see is pretty much the .gitignore you get when you create a repo on github and select "Node.js" as the type of project.
There was a problem hiding this comment.
But it also has unnecessary things, like .grunt. I feel that it is overkill, and thus we shouldn't use the word should. Do you see what I mean? Am I being unreasonable, here?
No description provided.