Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Front end design & cleanup #14

Merged
merged 6 commits into from
Dec 11, 2015
Merged

Conversation

dignifiedquire
Copy link
Member

Hopefully closes #11 soon.

Current version:

screen shot 2015-12-09 at 21 28 15

Todo

  • Design
    • Base styles
    • Implement scroll spy for navigation
    • Dividers
    • Logo
  • Development
    • Use webpack + harpjs for building
    • Live reloading all the things using browsersync
    • Linting with standard
    • Pull data from json/markdown files
  • Build step
    • Integrate harp compile into make
    • Integrate webpack build into make
  • Developer docs

You can run this via

$ npm install
$ npm i -g gulp
$ gulp serve
$ open http://localhost:3000

* JavaScript
* bundeling using webpack
* transpiling using babel
* Linting using eslint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these required? why can't we keep these out? it makes it daunting to modify websites when suddenly you have to know a ton more tools and know how to debug them when something goes wrong.

there's a lot to be said for simplicity and reducing cognitive complexity to the user.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of major points why I think we need them

  • Manage dependencies using npm
  • Consistency with other browser based modules like js-ipf-api
  • Make my life easier when working on the code (livereload is really a must for web dev for me)

The only thing that might not be needed is harpjs, though it was just a lot faster for me to use something working like that, than implementing all the tooling manually.

For me this is a lot simpler and more straight forward setup, especially while working with it than it was before. Also this enables me to add things like proper minification and asset bundeling which we need to have to ship this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sounds good. let's ship it

@jbenet
Copy link
Member

jbenet commented Dec 10, 2015

@dignifiedquire this looks fantastic 👍 👏 i think this is the way to go.

@jbenet
Copy link
Member

jbenet commented Dec 10, 2015

@dignifiedquire i'm super happy with how this turned out. thank you for taking all the feedback and finding a great way to satisfy all the crazy constraints, and still make it look great :) 👍

@dignifiedquire
Copy link
Member Author

@dignifiedquire this looks fantastic i think this is the way to go.

Thanks, happy to hear that 🎉 🎈

jbenet added a commit that referenced this pull request Dec 11, 2015
[WIP] Front end design & cleanup
@jbenet jbenet merged commit 4043cc9 into ipfs:master Dec 11, 2015
@jbenet
Copy link
Member

jbenet commented Dec 11, 2015

@dignifiedquire ahh sorry i merged too fast-- just recalled the open checkboxes. It's ok, maybe just continue with a PR on top.

@dignifiedquire
Copy link
Member Author

@jbenet no problem, will continue to create prs for the rest of the issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need better frontend design
2 participants