Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reversibility tests #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Reversibility tests #56

wants to merge 2 commits into from

Conversation

jbenet
Copy link
Member

@jbenet jbenet commented Feb 16, 2017

these test the code in #55

@jbenet
Copy link
Member Author

jbenet commented Feb 16, 2017

Im not sure these work, so putting in a different PR than #55 -- sorry, cant fix these up.

Kubuxu
Kubuxu reviewed Oct 16, 2017
View reviewed changes
Copy link
Member

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about the status of this. I think it is possible to revert repo and we might have tests for it.

@magik6k could you check?
cc @kevina as you worked on migrations

@magik6k
Copy link
Member

magik6k commented Oct 16, 2017

There is revert mode, though not all migrations test it

@jbenet @Stebalien
added tests for reversibility
efea866 
I cannot test these-- i dont have docker in osx. I would spend
more time but can't. Here's as far as i will get in the near future.
@ghost ghost assigned Stebalien Mar 19, 2019
@ghost ghost added the status/in-progress In progress label Mar 19, 2019
@Stebalien
Copy link
Member

Status: ipfs-update doesn't pass the --revert-ok flag so the migration backwards correctly fails. We'll likely need to add a flag to ipfs-update to allow this.

@kevina kevina requested review from Kubuxu and removed request for Kubuxu March 19, 2019 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubuxu Kubuxu Kubuxu left review comments

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees

@Stebalien Stebalien

Labels
status/in-progress In progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbenet @magik6k @Stebalien @Kubuxu