feat: add specs and user taxonomies #159
Conversation
laurentsenta
force-pushed
the
feat-with-specs
branch
from
3c0faab
to
e517e8f
Compare
laurentsenta
changed the title
laurentsenta
force-pushed
the
feat-with-specs
branch
from
00de7e3
to
07a5a32
Compare
|
Results against Kubo latest: Summary
|
|
Results against Kubo master: Summary
|
| @@ -541,6 +553,7 @@ func TestNativeDag(t *testing.T) { | |||
| }, | |||
| { | |||
| Name: Fmt("HEAD {{name}} with only-if-cached for missing block returns HTTP 412 Precondition Failed", row.Name), | |||
| Spec: "specs.ipfs.tech/http-gateways/path-gateway/#only-if-cached", | |||
There was a problem hiding this comment.
@laurentsenta lgtm, but cosmetic nit: dropping https: does not buy us much, could we keep full URLs?
It will enable us to use automated tools that find URLs in strings and report broken ones without extra step, users will be able to click the URL in their code editor etc.
There was a problem hiding this comment.
Will fix, thanks!
edit: done in #163
| @@ -73,6 +76,7 @@ func TestTar(t *testing.T) { | |||
| }, | |||
| { | |||
| Name: "GET TAR with explicit ?filename= succeeds with modified Content-Disposition header", | |||
| Spec: "specs.ipfs.tech/http-gateways/path-gateway/#content-disposition-response-header", | |||
There was a problem hiding this comment.
@laurentsenta thoughts on having Specs version which allows for more than 1 URL? I imagine there will be cases where more than one spec is relevant.
There was a problem hiding this comment.
Thought about it, you can use Specs! https://github.com/ipfs/gateway-conformance/pull/159/files#diff-73ca403802a777f0a38d9aed0daa6f62819960272f8997e91c7eb6bd6782935fR17
Contributes to #123
Add a "User Taxonomy" different from the specs. This will be used in gateway checker and other user-facing tooling.
Add specs that connect with specs.ipfs.tech
Follow-ups: