Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape names that might collide with other operations #166

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

laurentsenta
Copy link
Contributor

@laurentsenta laurentsenta commented Sep 15, 2023

Fixes the log rendering issue we've seen in bifrost

https://github.com/singulargarden/bifrost-gateway/actions/runs/6157325821/job/16707825616

Calling t.Run("this is a test for /ipfs/something", ...) will create outputs names like:

  • TestRoot/TestParent/this_is_a_test_for/ipfs/something/Body

Which breaks the test generations and creates a weird structure when rendering the tests.

  • Use HTML encoding to escape these names.
  • check the output and maybe un-encode

Examples:

@github-actions
Copy link
Contributor

Results against Kubo latest:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
1853 11 0 0

@github-actions
Copy link
Contributor

Results against Kubo master:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
1853 0 0 0

@laurentsenta laurentsenta force-pushed the fix-naming branch 2 times, most recently from 754d71c to ff0dee8 Compare September 15, 2023 13:44
@laurentsenta laurentsenta merged commit 78aa307 into main Sep 15, 2023
13 of 15 checks passed
@github-actions github-actions bot mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant