-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dedicated target per gateway specification and smaller-range groups #79
Conversation
The PR is ready to looked at. Note that I updated the PR description with all the new information. It seems that the tests are stuck "provisioning Kubo gateway" and I'm not sure what's wrong as I did not change any of the fixtures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, investigating why CI breaks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @hacdias, lgtm!
I've dropped some unrelated TODOs for future PRs (things I've noticed while looking at this PR), but as for this PR, it's only missing docs (outline of mvp readme below).
Ideally, we should have all specifications defined and some (all?) would run by default. Then the user can tinker with it.
Yes, by default we run all, and then user can adjust, if required.
I think this PR should also include section in README about this.
Questions we want to have answered there:
- what is run by default (all mature tests)
- opt-outs
- how user can skip specific test group (example: disable subdomain and dnslink gateways)
- how user can skip individual test (example:
-skip
is used in Kubo CI here but not documented anywhere in readme atm, and Saturn folks thought it is not possible)
- how user can disable all tests and run only specific group
- including example how to run only the trustless raw+car but without ipns will be enough
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Close #74. Close #78. This PR does the following:
+TrustlessGateway -TrustlessGatewayIPNS
will run CARs and RAW tests./ipfs/{cid}?format=raw
Run
such that all tests are attached to some specification.What this PR is not:
Some notes:
{ dnslink-fqdn-inline }.ipns.{domain}
) is not a DNSLink gateway.I will also need some feedback here from @galargh @lidel @laurentsenta. Ideally, we should have all specifications defined and some (all?) would run by default. Then the user can tinker with it.
I think the most complicated part is defining subsets. For example: Trustless Gateway is a subset of the Path Gateway. Therefore, if I run the tests for the Path Gateway, I should also be running the Trustless Gateway tests, and so on and so forth.