This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
aggressively free memory #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
commented
Jun 14, 2019
|
|
||
| return pbw.WriteMsg(m.ToProtoV1()) | ||
| func write(w io.Writer, m *pb.Message) error { |
There was a problem hiding this comment.
I wonder if we should put this in a library somewhere? I'm going to need it in the DHT.
|
This is showing up on the gateways. |
This ensures we don't keep large buffers allocated.
Stebalien
force-pushed
the
fix/free-memory
branch
from
07abee7 to
70fd0fd
Compare
|
@Stebalien is there some context for this? |
|
The gateway was locking up a gigabyte in gogo readers: https://github.com/ipfs/go-bitswap/pull/143/files#diff-33bf651b39540d23d5b24eb4a54026cdL181. This patch:
Importantly, it doesn't just hang onto this buffer till the next message comes in. |
message/message.go
Outdated
| if err := pb.Unmarshal(msg); err != nil { | ||
| return nil, err | ||
| } | ||
| r.ReleaseMsg(msg) |
There was a problem hiding this comment.
is your enter key not working?
| size := m.Size() | ||
| buf := pool.Get(size + binary.MaxVarintLen64) | ||
| defer pool.Put(buf) | ||
| n := binary.PutUvarint(buf, uint64(size)) |
There was a problem hiding this comment.
what did whitespace ever do to you?
whyrusleeping
approved these changes
Jun 19, 2019
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
aggressively free memory This commit was moved from ipfs/go-bitswap@5628965
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on libp2p/go-msgio#15