Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Clean up logs #299

Merged
merged 2 commits into from
Mar 16, 2020
Merged

Clean up logs #299

merged 2 commits into from
Mar 16, 2020

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Mar 13, 2020

No description provided.

Stebalien
Stebalien suggested changes Mar 13, 2020
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit concerned about the performance hit. While these debug log statements won't actually do anything under the covers, we'll still have to allocate, copy, and iterate more than we should.

internal/wantmanager/wantmanager.go Outdated Show resolved Hide resolved
internal/wantmanager/wantmanager.go Outdated Show resolved Hide resolved
internal/session/sessionwantsender.go Show resolved Hide resolved
internal/session/session.go Outdated Show resolved Hide resolved
internal/messagequeue/messagequeue.go Show resolved Hide resolved
internal/messagequeue/messagequeue.go Show resolved Hide resolved
@Stebalien Stebalien merged commit bced0f3 into master Mar 16, 2020
@Stebalien Stebalien deleted the refactor/log-cleanup branch March 16, 2020 16:48
@dirkmc dirkmc mentioned this pull request Apr 7, 2020
Closed
Jorropo pushed a commit to Jorropo/go-libipfs that referenced this pull request Jan 26, 2023
@Stebalien
Merge pull request ipfs/go-bitswap#299 from ipfs/refactor/log-cleanup
e58d776 
Clean up logs

This commit was moved from ipfs/go-bitswap@bced0f3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirkmc @Stebalien