This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#308 may be a better solution to the CID size issues. |
So, the race is actually in the tests. It looks like the virtual network hangs on to the message (and doesn't even bother serializing). We can probably just round-trip through a protobuf message with a bit of work. |
Stebalien
reviewed
Mar 19, 2020
It looks like the races are only showing up in the tests, I will go through and fix them |
dirkmc
force-pushed
the
perf/message-queue
branch
from
March 19, 2020 15:39
a10ca03
to
b4763e2
Compare
I updated the perf timings in the initial post at the top of this PR |
Stebalien
approved these changes
Mar 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
Perf/message queue This commit was moved from ipfs/go-bitswap@89d39a6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #306
go test -run=XXX -benchtime=20s -bench=. -cpuprofile prof.out
Creating a new message
Old:
New:
Adding an entry to the message
Old:
New:
Getting the wantlist
Old:
Seems a little faster, but I think things may just have moved around. In any case we're calling it once now instead of twice:
New: