This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
Fix ProviderQueryManager test timings #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix several sensitive timings on ProviderQueryManager tests that could lead to intermittent failures in CI
hannahhoward
force-pushed
the
fix/flaky-test-rate-limiting-requests
branch
from
a2e8191
to
e002540
Compare
|
note while some CI is still failing none of the failures trace to the provider query manager |
|
part of ipfs/boxo#86 |
Stebalien
approved these changes
Oct 14, 2021
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
…limiting-requests Fix ProviderQueryManager test timings This commit was moved from ipfs/go-bitswap@462f628
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
The provider query manager had several sensitive test timings in it. These could fail in CI. I determined they were the cause of the failure by the test execution time, which matched the time outs.
Implementation
Adjust sensitive timings (mostly 100ms overall test timeouts) to account for unpredictable CI execution