Improve peer connection handling #590
Conversation
|
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
|
Looks like different tests failed in each of the suites. All tests pass locally. I'm happy to fix/add tests if you're ok with the changes. |
| if peu, ok := evt.(event.EvtPeerProtocolsUpdated); ok { | ||
| if bsnet.hasBitswapProtocol(peu.Added) { | ||
| log.Debugf("connecting to peer with updated protocol list: %s", peu.Peer) | ||
| bsnet.connectEvtMgr.Connected(peu.Peer) | ||
| continue | ||
| } | ||
|
|
||
| if bsnet.hasBitswapProtocol(peu.Removed) && !bsnet.peerSupportsBitswap(peu.Peer) { | ||
| log.Debugf("disconnecting from peer with updated protocol list: %s", peu.Peer) | ||
| bsnet.connectEvtMgr.Disconnected(peu.Peer) | ||
| } | ||
| continue | ||
| } | ||
|
|
||
| if peic, ok := evt.(event.EvtPeerIdentificationCompleted); ok { |
|
This repository has been moved to https://github.com/ipfs/go-libipfs. There is not an easy way to transfer PRs, so if you would like to continue with this PR then please re-open it in the new repository and link to this PR. |
Currently, the bitswap network only adds peers to its client/server peer lists that connected after the network has started. This means the network must be started before enabling the libp2p listeners, otherwise some peers may connect too early and never be added to the network.
To address this, this PR updates the bitswap network's
Start()method to first, listen for new peer connection events, and then iterate through all peers and add any that support the bitswap protocols. The issue and solution were originally described by @Stebalien in ipfs/boxo#83.