use filepath walk for flatfs query #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| return query.ResultsWithEntries(q, res), nil | ||
| } | ||
| if !info.Mode().IsRegular() || info.Name()[0] == '.' { |
There was a problem hiding this comment.
I think the intent of this check was to ignore the random dotfiles that os'es (OSX) will randomly decide to put in folders. Other than that, i'm not certain.
There was a problem hiding this comment.
Oh name[0], we're good.
On Sun, Dec 13, 2015 at 22:10 Jeromy Johnson notifications@github.com
wrote:
In flatfs/flatfs.go
#34 (comment):
- var res []query.Entry
- prefixes, err := root.Readdir(0)
- if err != nil {
return nil, err- }
- for _, fi := range prefixes {
var err errorres, err = fs.enumerateKeys(fi, res)if err != nil {return nil, err}- }
- return query.ResultsWithEntries(q, res), nil
-}if !info.Mode().IsRegular() || info.Name()[0] == '.' {I think the intent of this check was to ignore the random dotfiles that
os'es (OSX) will randomly decide to put in folders. Other than that, i'm
not certain.—
Reply to this email directly or view it on GitHub
https://github.com/jbenet/go-datastore/pull/34/files#r47458423.
|
this LGTM |
jbenet
added a commit
that referenced
this pull request
Dec 14, 2015
use filepath walk for flatfs query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
running a query on a large ipfs datastore takes forever (and uses a lot of ram), this should help, some.