use filepath walk for flatfs query

[whyrusleeping]

running a query on a large ipfs datastore takes forever (and uses a lot of ram), this should help, some.

[jbenet]

. but no ..?

[whyrusleeping]

I think the intent of this check was to ignore the random dotfiles that os'es (OSX) will randomly decide to put in folders. Other than that, i'm not certain.

[jbenet]

Oh name[0], we're good.
On Sun, Dec 13, 2015 at 22:10 Jeromy Johnson notifications@github.com
wrote:

In flatfs/flatfs.go
#34 (comment):

• var res []query.Entry
• prefixes, err := root.Readdir(0)
• if err != nil {

•   return nil, err
  

• }
• for _, fi := range prefixes {

•   var err error
  

•   res, err = fs.enumerateKeys(fi, res)
  

•   if err != nil {
  

•       return nil, err
  

•   }
  

• }
• return query.ResultsWithEntries(q, res), nil
  -}

•       if !info.Mode().IsRegular() || info.Name()[0] == '.' {
  

I think the intent of this check was to ignore the random dotfiles that
os'es (OSX) will randomly decide to put in folders. Other than that, i'm
not certain.

—
Reply to this email directly or view it on GitHub
https://github.com/jbenet/go-datastore/pull/34/files#r47458423.

[jbenet]

this LGTM