Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Add metrics #58

Closed
guseggert opened this issue Oct 14, 2022 · 3 comments · Fixed by #59
Closed

Add metrics #58

guseggert opened this issue Oct 14, 2022 · 3 comments · Fixed by #59
Assignees
Labels
kind/enhancement A net-new feature or improvement to an existing feature P0 Critical: Tackled by core team ASAP

Comments

@guseggert
Copy link
Contributor

This library should emit both OpenCensus metrics in both the client and server. We'll start with the standard set of metrics:

  • Number of reqs
  • Latency
  • Errors

And modeled after what we've found useful for operating the Hydras: https://github.com/libp2p/hydra-booster/blob/master/providers/reframe.go#L49

@guseggert guseggert added the need/triage Needs initial labeling and prioritization label Oct 14, 2022
@welcome
Copy link

welcome bot commented Oct 14, 2022

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@guseggert guseggert self-assigned this Oct 14, 2022
@guseggert guseggert added P0 Critical: Tackled by core team ASAP and removed need/triage Needs initial labeling and prioritization labels Oct 14, 2022
@guseggert guseggert moved this to 🏃‍♀️ In Progress in IPFS Shipyard Team Oct 14, 2022
@guseggert guseggert added the kind/enhancement A net-new feature or improvement to an existing feature label Oct 14, 2022
@guseggert
Copy link
Contributor Author

For metric publishing and logging it'd be nice to include some context about which router had a problem (like its name, URL, or something like that). The APIs are designed in a way that make this pretty difficult. We can fix this in a subsequent update, will open an issue once I clarify what we need.

@guseggert guseggert linked a pull request Oct 17, 2022 that will close this issue
@BigLep BigLep moved this from 🏃‍♀️ In Progress to 🔎 In Review in IPFS Shipyard Team Oct 18, 2022
Repository owner moved this from 🔎 In Review to 🎉 Done in IPFS Shipyard Team Oct 19, 2022
@guseggert
Copy link
Contributor Author

plumbed into kubo: ipfs/kubo#9354

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement A net-new feature or improvement to an existing feature P0 Critical: Tackled by core team ASAP
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant