This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
feat: add latency & count metrics for content routing client #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guseggert
force-pushed
the
feat/metrics
branch
3 times, most recently
from
9dfc67d to
a7c1f56
Compare
Closed
ajnavarro
approved these changes
Oct 18, 2022
client/metrics.go
Outdated
| } else if errors.Is(err, context.DeadlineExceeded) { | ||
| errStr = "DeadlineExceeded" | ||
| } else { | ||
| errStr = "Unknown" |
There was a problem hiding this comment.
Do you think that might be a problem to set the err.Error() here instead of Unknown?
There was a problem hiding this comment.
Yes, if the error message has something dynamic in it like an address or some data from the request then it could cause high cardinality which is bad (availability risk for Prometheus, makes the metrics noisy and expensive to query).
There was a problem hiding this comment.
This is why I also added a log statement, if you see "Unknown" and want to dig in more, you can look at logs.
guseggert
force-pushed
the
feat/metrics
branch
from
a7c1f56 to
d0a2ecc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.