-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace badger v1 with v2 #101
Comments
Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
Finally, remember to use https://discuss.ipfs.io if you just need general support. |
@mvdan we have https://github.com/ipfs/go-ds-badger2 for Badger 2. Arguably there was a better go mod way to do this, but it definitely makes releasing patches to the badger1 and badger2 datastores at the same time less error prone. However, if you'd like to help with some of the plugging in of this into go-ipfs then that would definitely be welcome. |
Oh jeez, I'm not sure how I missed that :) Perhaps add a clear notice in the README in this repo? Because if you don't know where to look, it's very easy to miss the newer library, like I did. I'm interested to hear how two git repositories make maintaining both versions at the same time easier, though. I maintain multiple major versions of modules in a few git repositories and it's generally easy enough to do. |
Seems reasonable 😄
You'd have to ask @Kubuxu, but it looks like there were some concerns mentioned in ipfs/kubo#6818. I can't speak to why he did it that way, but if I were in his shoes I probably would've done the same thing. go mod has enough complexity and corner cases such that if you were trying to just get this moving then copying the repo is the approach that's guaranteed to just work™. |
Readme updated #102 |
If any extra experience counts, I've switched a couple of live projects to v2 earlier this year, and so far zero issues. |
BadgerDB v2 has been out for nearly a year, and it's overall better in multiple ways and better supported.
It shouldn't be too difficult to switch, either:
Would a PR be welcome here?
The text was updated successfully, but these errors were encountered: