Badger 2

[Stebalien]

Badger has released a new version that's format incompatible with the previous version. We have several options:

1. Ignore it. Not a good solution as version 1 isn't maintained.
2. Switch to it directly.
   • We'd need a migration. Badger 1 is experimental but enough users are using it that we can't just say "yolo, re-create your repos".
   • We'd go from a almost stable datastore right back to "we're not sure how stable this is".
3. Add an option to the go-ds-badger datastore to specify the underlying badger version.
   • Pro: this is pretty simple to implement. We should be able to import both versions of badger into go-ipfs.
   • Con: no way for users to opt out of the old badger if they want to decrease their binary size.
4. Treat it like a new datastore:
   a. **Create a new go-ds-badger2 repo.&&
   b. Release a v1 of go-ds-badger for badger 1, then release a v2 for badger 2. This is the "go mod" way to do this however, the go-datastore interfaces may not be stable enough to do this.

I'm currently leaning towards option 3.

We have gone with 4.a (thanks @Kubuxu!).

[Stebalien]

@Kubuxu has implemented 4.a: https://github.com/ipfs/go-ds-badger2.

[Stebalien]

@aschmahmann when you get a moment, could you add a new datastore type for badger2?

[aschmahmann]

@Stebalien would you like me to include modifying https://github.com/ipfs/ipfs-ds-convert to handle Badger2?

[Stebalien]

I'd punt on that for now. Fixing the DHT is a higher priority.