Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix combining query filters, offsets, and limits #71

Merged
merged 4 commits into from
Oct 1, 2019
Merged

Conversation

Stebalien
Copy link
Member

Also, use built-in "prefix" feature instead of seeking.

Tested by ipfs/go-datastore#136

Avoid looking at tables that don't have keys we're looking for.
@Stebalien Stebalien requested a review from dirkmc October 1, 2019 15:27
Pulls in the new test suite.
Copy link

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit but otherwise LGTM

Is there a test that covers these changes?

datastore.go Outdated Show resolved Hide resolved
@Stebalien
Copy link
Member Author

Is there a test that covers these changes?

I just pushed the update go-datastore package that includes a query test suite.

@Stebalien Stebalien merged commit 0bb48f3 into master Oct 1, 2019
@Stebalien Stebalien deleted the fix/query branch October 1, 2019 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants