-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update go-ipld-format and boxo to remove globals #201
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
go.mod
Outdated
github.com/ipfs/boxo v0.8.2-0.20230602131956-922a186d9cef | ||
github.com/ipfs/go-cid v0.4.0 | ||
github.com/ipfs/go-datastore v0.6.0 | ||
github.com/ipfs/go-ds-badger v0.3.0 | ||
github.com/ipfs/go-ipld-format v0.4.0 | ||
github.com/ipfs/go-ipld-format v0.4.1-0.20230530195241-c3da01c74a06 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: need released versions
func init() { | ||
ipld.Register(cid.DagProtobuf, dag.DecodeProtobufBlock) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclear that this is used for anything in this repo. Is there anything I'm missing here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well it seems it is not really needed. Perhaps it was needed once upon a time, or I just feared the NodeGetter wouldn't be able to parse anything. (I suspect this codec may be registered by default somewhere else?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it used to be registered by go-merkledag, although I'm not sure it's even needed here anymore
LGTM, pending bubbling etc. |
b879ef1
to
d4b2894
Compare
d4b2894
to
e0b06c5
Compare
e0b06c5
to
7e25623
Compare
No description provided.