Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update go-ipld-format and boxo to remove globals #201

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

aschmahmann
Copy link
Contributor

No description provided.

@welcome
Copy link

welcome bot commented Jun 5, 2023

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

go.mod Outdated
Comment on lines 9 to 13
github.com/ipfs/boxo v0.8.2-0.20230602131956-922a186d9cef
github.com/ipfs/go-cid v0.4.0
github.com/ipfs/go-datastore v0.6.0
github.com/ipfs/go-ds-badger v0.3.0
github.com/ipfs/go-ipld-format v0.4.0
github.com/ipfs/go-ipld-format v0.4.1-0.20230530195241-c3da01c74a06
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: need released versions

Comment on lines -18 to -20
func init() {
ipld.Register(cid.DagProtobuf, dag.DecodeProtobufBlock)
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclear that this is used for anything in this repo. Is there anything I'm missing here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it seems it is not really needed. Perhaps it was needed once upon a time, or I just feared the NodeGetter wouldn't be able to parse anything. (I suspect this codec may be registered by default somewhere else?).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it used to be registered by go-merkledag, although I'm not sure it's even needed here anymore

@hsanjuan
Copy link
Collaborator

hsanjuan commented Jun 6, 2023

LGTM, pending bubbling etc.

@aschmahmann aschmahmann force-pushed the feat/remove-ipld-format-globals branch from b879ef1 to d4b2894 Compare June 13, 2023 20:01
@aschmahmann aschmahmann marked this pull request as ready for review June 13, 2023 20:01
@aschmahmann aschmahmann force-pushed the feat/remove-ipld-format-globals branch from d4b2894 to e0b06c5 Compare June 13, 2023 20:03
@aschmahmann aschmahmann force-pushed the feat/remove-ipld-format-globals branch from e0b06c5 to 7e25623 Compare June 13, 2023 21:18
@lidel lidel requested a review from hsanjuan August 7, 2023 13:28
@hsanjuan hsanjuan merged commit a73d7f8 into master Aug 8, 2023
@hsanjuan hsanjuan deleted the feat/remove-ipld-format-globals branch August 8, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants