Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query: always return the size #35

Merged
merged 1 commit into from
Dec 3, 2019
Merged

query: always return the size #35

merged 1 commit into from
Dec 3, 2019

Conversation

MichaelMure
Copy link
Contributor

fix #34

@MichaelMure MichaelMure mentioned this pull request Nov 27, 2019
Merged
Stebalien
Stebalien approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Blocked on ipfs/go-datastore#134.

@Stebalien Stebalien added the status/blocked Unable to be worked further until needs are met label Dec 2, 2019
@MichaelMure
Copy link
Contributor Author

Not blocked anymore.

@Stebalien Stebalien merged commit 9ad1663 into ipfs:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
status/blocked Unable to be worked further until needs are met
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support for Query.ReturnSizes
2 participants
@MichaelMure @Stebalien