This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
Switch to Dagpb and incorporate LinkSystem changes #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdan
approved these changes
Mar 17, 2021
fetcher.go
Outdated
| if ok { | ||
| switch c.Cid.Prefix().Codec { | ||
| case 0x70: | ||
| return dagpb.Type.PBNode, nil |
There was a problem hiding this comment.
you can use ipld/go-codec-dagpb@b641b0f now.
you also don't need the raw special case, as basicnode.Prototype.Any will already work fine for raw nodes, picking Bytes.
There was a problem hiding this comment.
I made this change.
Jorropo
pushed a commit
to ipfs/go-libipfs-rapide
that referenced
this pull request
Mar 23, 2023
Switch to Dagpb and incorporate LinkSystem changes This commit was moved from ipfs/go-fetcher@b9a3f1a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It appears we will be using go-codecs-dagpb instead of go-ipld-prime-proto as our ipld implemenation of protobuf nodes. Also the LinkSystem changes in go-ipld-prime will be landing soon. This PR supports both of those changes.
This PR will cease to be a draft when the LinkSystem changes land and this package depends on a release tag of go-ipld-prime.
Proposed Changes
AddDagPBSupportToChooserfrom go-ipld-prime-proto withDefaultPrototypeChooserimplementation.