This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
Add NodeReifier to fetcher config #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
force-pushed
the
feat/augment-node-builder-chooser
branch
from
96439c9
to
7fc88c4
Compare
|
is this still needed with reification merged? |
hannahhoward
changed the title
hannahhoward
force-pushed
the
feat/augment-node-builder-chooser
branch
from
58c7cc8
to
d4187fb
Compare
warpfork
reviewed
Apr 2, 2021
fetcher.go
Outdated
| @@ -186,3 +200,5 @@ var DefaultPrototypeChooser = dagpb.AddSupportToChooser(func(lnk ipld.Link, lnkC | |||
| } | |||
| return basicnode.Prototype.Any, nil | |||
| }) | |||
|
|
|||
| var DefaultReifier = unixfsnode.Reify | |||
There was a problem hiding this comment.
Having this as a default in this library seems maybe kinda questionable to me. I don't know exactly where we'd put this library on a graph/layercake/whatever-drawing-format of dependencies and what semantic level we expect of them. But in general I'd support trying to push this as high as possible.
Especially since the default/nil value is functional without being configured.
There was a problem hiding this comment.
yea no it doesn't have to go there. I'm mixed about it being there. I think it ties us too much to the IPFS case. Think I'll take it out.
willscott
approved these changes
Apr 5, 2021
Jorropo
pushed a commit
to ipfs/go-libipfs-rapide
that referenced
this pull request
Mar 23, 2023
…lder-chooser Add NodeReifier to fetcher config This commit was moved from ipfs/go-fetcher@3290471
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Allow configuration of the NodeReifier on Fetcher
Defaults to UnixFS Reifer
Implementation
For Discussion
We could skip the defaulting to the unixfs reifier and push that configuration up — seems unlikely we’ll want to do that though. Then again, ResolveOnce that used to exist in GoPath was the equivalent — and that configuration lived at go-ipfs level