Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send first blocks extension #230

Merged
merged 5 commits into from
Sep 29, 2021

Conversation

hannahhoward
Copy link
Collaborator

@hannahhoward hannahhoward commented Sep 29, 2021

Goals

Implement #225

Implementation

  • add the extension name an a utility to encode decode the data (just a number)
  • add processing of the extension to the query preparer
  • handle behavior for the extension in the response assembler. You can now specify a number of blocks (** non-unique **) on a request to traverse before they start going over the wire.
  • add integration test to demonstrate flow

define extension and add processing to response manager
add test demonstrating do not send first blocks flow
donotsendfirstblocks/donotsendfirstblocks.go Outdated Show resolved Hide resolved
impl/graphsync_test.go Outdated Show resolved Hide resolved
hannahhoward and others added 2 commits September 29, 2021 16:54
Co-authored-by: Will <will.scott@protocol.ai>
Co-authored-by: Will <will.scott@protocol.ai>
@hannahhoward hannahhoward merged commit 57df640 into main Sep 29, 2021
@rvagg
Copy link
Member

rvagg commented Sep 30, 2021

nice, is it go-datatransfer that becomes responsible for using this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants