Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an index for blocks in the on new block hooks #234

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Add an index for blocks in the on new block hooks #234

merged 1 commit into from
Sep 30, 2021

Conversation

hannahhoward
Copy link
Collaborator

Goals

Make it easier to tell how many blocks have been traversed

Implementation

  • Add an Index() value for block data
  • Set it for blocks pays to Incoming and Outgoing block hooks.

@hannahhoward hannahhoward merged commit bc8e6b1 into main Sep 30, 2021
@rvagg
Copy link
Member

rvagg commented Oct 1, 2021

@hannahhoward can you explain the use of the int64 instead of uint64 here?

@dirkmc dirkmc mentioned this pull request Oct 5, 2021
Merged
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
Closed
80 tasks
@mvdan mvdan deleted the feat/add-block-index branch December 15, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willscott willscott willscott approved these changes

@dirkmc dirkmc Awaiting requested review from dirkmc

@rvagg rvagg Awaiting requested review from rvagg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hannahhoward @rvagg @willscott