Fix flakiness TestCancellationViaCommand #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
reviewed
Oct 7, 2021
| waitForCancel := make(chan struct{}) | ||
| td.blockHooks.Register(func(p peer.ID, requestData graphsync.RequestData, blockData graphsync.BlockData, hookActions graphsync.OutgoingBlockHookActions) { | ||
| if blkCount == 1 { | ||
| <-waitForCancel |
There was a problem hiding this comment.
so this blocks and we won't increment blkCount until the close on line 121. but nothing checks blkCount directly so this is about blocking the blockHook processing?
There was a problem hiding this comment.
yea
I can comment to be clear
willscott
approved these changes
Oct 7, 2021
hannahhoward
force-pushed
the
fix/flaky-cancellation-via-command
branch
from
4fb747d
to
dcccffc
Compare
Resolve issue that caused TestCancellationViaCommand to sometimes fail as the request was already finished
hannahhoward
force-pushed
the
fix/flaky-cancellation-via-command
branch
from
dcccffc
to
e498932
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
TestCancellationViaCommand contained a race condition that would cause the response to sometimes finish processing before it could be cancelled.
Implementation
Setup a block hook to hold processing of the response till the CancelResponse call is issued, unblock once command is issued