Configure message parameters #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
force-pushed
the
feat/increase-fail-speed
branch
from
5a8b5a7
to
c684447
Compare
allow setting custom values for timing out messages and number of retries
hannahhoward
force-pushed
the
feat/increase-fail-speed
branch
from
c684447
to
f71db14
Compare
rvagg
reviewed
Oct 13, 2021
rvagg
reviewed
Oct 13, 2021
rvagg
approved these changes
Oct 13, 2021
Co-authored-by: Rod Vagg <rod@vagg.org>
Co-authored-by: Rod Vagg <rod@vagg.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Currently, for each network message, graphsync attempts to send it for 10 minutes, then if it fails, retries 10 times. So for a network message to truly fail, it takes 100 minutes. This seems like an extremely long time.
Implementation