Fix flaky tests #287
Merged
Fix flaky tests #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
also my M1 machine fails to get any failures reliably, even with counts > 1000. So I'm not sure how to test other than push to CI. |
rvagg
reviewed
Nov 30, 2021
rvagg
approved these changes
Nov 30, 2021
Member
rvagg
left a comment
rvagg
left a comment
There was a problem hiding this comment.
Started my repro loop on this branch and forgot about it, came back and it was still running with no failures now that it's done on assertCompleteRequestWith().
Also, I've just found a need to implement almost the exact same code RequestManager, getting the executor wait until the request is fully released so I can properly collect traces.
This is a good pattern because it means we have more strict bounds on the parallelism with no lose edges.
This was referenced Nov 30, 2021
marten-seemann
pushed a commit
that referenced
this pull request
Mar 2, 2023
* feat(graphsync): check current peer channels new method gets diagnostics on current dt-channel id -> request id mapping, also fixes up some logging * docs(graphsync): add some code comments
marten-seemann
pushed a commit
that referenced
this pull request
Mar 2, 2023
Improve GraphSync Transport Diagnostics (#287) * feat(graphsync): check current peer channels new method gets diagnostics on current dt-channel id -> request id mapping, also fixes up some logging * docs(graphsync): add some code comments fix(deps): update go-graphsync v0.10.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rvagg I believe your WaitForNoActiveTasks was just one small concurrency fix away from being the solution. The issue here is that FinishTask is currently an asynchronous call -- it simply sends the finish message to the response manager and moves on. That means the worker queue can finish draining before the response manager thread actually processes the finish message.
The easy solution, or at least the proof of concept solution, is simply to make the FinishTask method synchronous - it doesn't return till the message is processed (this is done by using a return channel).