Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ipld): use bindnode/registry #386

Merged
merged 2 commits into from
Jun 25, 2022
Merged

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jun 16, 2022

Same set of breaking changes introduced by go-cid through go-ipld-prime: ipfs/go-cid#137 that have had a flow-on impact through go-libp2p libraries.

@rvagg
Copy link
Member Author

rvagg commented Jun 17, 2022

cool, and this matches go-ipfs dependencies and works, so I'm going to take this, and filecoin-project/go-data-transfer#340, as permission to cut that go-ipld-prime@0.17.0

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannahhoward hannahhoward merged commit a95496c into main Jun 25, 2022
@hannahhoward
Copy link
Collaborator

Gonna merge with the caveat that we should import the tagged version prior to next tagging in graphsync

@rvagg rvagg deleted the rvagg/bindnode-registry branch June 25, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants