Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

chore: use common ipfs/start-ipfs-daemon-action in go-test-setup #262

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Dec 14, 2021

I want to replace the ipfs init and ipfs daemon calls here with a common action(https://github.com/ipfs/start-ipfs-daemon-action) to minimise duplication. This is part of work related to this issue: ipfs/kubo#8511

The workflow passes after the changes introduced by me: https://github.com/ipfs/go-ipfs-api/actions/runs/1579095670

@galargh galargh requested a review from lidel December 14, 2021 18:43
@welcome
Copy link

welcome bot commented Dec 14, 2021

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@lidel lidel merged commit 21de539 into master Dec 15, 2021
@lidel lidel deleted the go-ipfs-dedup branch December 15, 2021 13:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants